Refactored tests (Velocidex#1194)

Makefile

@@ -62,3 +62,6 @@ debug_golden:
 
 lint:
 	golangci-lint run
+
+KapeFilesSync:
+	python3 scripts/kape_files.py ~/projects/KapeFiles/ > artifacts/definitions/Windows/KapeFiles/Targets.yaml

api/notebooks.go

@@ -743,6 +743,11 @@ func (self *ApiServer) updateNotebookCell(
 			ListenForNotification(in.CellId)
 		defer remove_notification()
 
+		default_notebook_expiry := self.config.Defaults.NotebookCellTimeoutMin
+		if default_notebook_expiry == 0 {
+			default_notebook_expiry = 10
+		}
+
 		select {
 		// Query is done - get out of here.
 		case <-query_ctx.Done():
@@ -752,7 +757,7 @@ func (self *ApiServer) updateNotebookCell(
 			tmpl.Scope.Log("Cancelled after %v !", time.Since(start_time))
 
 			// Set a timeout.
-		case <-time.After(10 * time.Minute):
+		case <-time.After(time.Duration(default_notebook_expiry) * time.Minute):
 			tmpl.Scope.Log("Query timed out after %v !", time.Since(start_time))
 		}
 

artifacts/definitions/Demo/Plugins/GUI.yaml

@@ -188,3 +188,20 @@ sources:
           check it is being updated.
 
           {{ Scope "Timeline" | Timeline }}
+
+      - type: VQL
+        template: |
+          /*
+          # Test table scrolling.
+
+          Check both expanded and contracted states of the cell
+          */
+          LET Test = "Hellothereongline"
+
+          SELECT Test AS Test1, Test AS Test2, Test AS Test3,
+                 Test AS Test4, Test AS Test5,
+                 Test AS Test11, Test AS Test21,
+                 Test AS Test13, Test AS Test14, Test AS Test15,
+                 Test AS Test21, Test AS Test22,
+                 Test AS Test23, Test AS Test24, Test AS Test25
+          FROM range(start=0, end=100, step=1)

artifacts/definitions/Linux/Search/FileFinder.yaml

@@ -35,9 +35,16 @@ precondition:
 
 parameters:
   - name: SearchFilesGlob
-    default: /home/*/**
+    default: /home/*
     description: Use a glob to define the files that will be searched.
 
+  - name: SearchFilesGlobTable
+    type: csv
+    default: |
+      Glob
+      /home/someuser/*
+    description: Alternative specify multiple globs in a table
+
   - name: Keywords
     default:
     description: A comma delimited list of strings to search for.
@@ -69,7 +76,7 @@ sources:
                Mtime AS MTime,
                Ctime AS CTime,
                IsDir, Mode
-        FROM glob(globs=SearchFilesGlob,
+        FROM glob(globs=SearchFilesGlobTable.Glob + SearchFilesGlob,
                   accessor="file")
 
     - LET more_recent = SELECT * FROM if(

artifacts/definitions/Windows/Search/FileFinder.yaml

@@ -35,9 +35,16 @@ precondition:
 
 parameters:
   - name: SearchFilesGlob
-    default: C:\Users\**
+    default: C:\Users\*
     description: Use a glob to define the files that will be searched.
 
+  - name: SearchFilesGlobTable
+    type: csv
+    default: |
+      Glob
+      C:/Users/SomeUser/*
+    description: Alternative specify multiple globs in a table
+
   - name: Accessor
     default: auto
     description: The accessor to use
@@ -72,7 +79,8 @@ sources:
                Atime AS ATime,
                Mtime AS MTime, "" AS Keywords,
                Ctime AS CTime, IsDir
-        FROM glob(globs=SearchFilesGlob, accessor=Accessor)
+        FROM glob(globs=SearchFilesGlobTable.Glob + SearchFilesGlob,
+                  accessor=Accessor)
 
       LET more_recent = SELECT * FROM if(
         condition=MoreRecentThan,

config/config.go

@@ -164,6 +164,10 @@ func GetDefaultConfig() *config_proto.Config {
 			BindPort:    8003,
 		},
 		ApiConfig: &config_proto.ApiClientConfig{},
+		Defaults: &config_proto.Defaults{
+			HuntExpiryHours:        24 * 7,
+			NotebookCellTimeoutMin: 10,
+		},
 	}
 
 	// The client's version needs to keep in sync with the

config/loader.go

@@ -265,6 +265,25 @@ func (self *Loader) WithEnvLoader(env_var string) *Loader {
 	return self
 }
 
+func (self *Loader) WithEnvLiteralLoader(env_var string) *Loader {
+	self = self.Copy()
+	self.loaders = append(self.loaders, func(self *Loader) (*config_proto.Config, error) {
+		env_config := os.Getenv(env_var)
+		if env_config != "" {
+			self.Log("Loading literal config from env %v", env_var)
+			result := &config_proto.Config{}
+			err := yaml.UnmarshalStrict([]byte(env_config), result)
+			if err != nil {
+				return nil, errors.WithStack(err)
+			}
+			return result, nil
+		}
+		return nil, errors.New(fmt.Sprintf("Env var %v is not set", env_var))
+	})
+
+	return self
+}
+
 func (self *Loader) WithEmbedded() *Loader {
 	self = self.Copy()
 	self.loaders = append(self.loaders, func(self *Loader) (*config_proto.Config, error) {

config/migration.go

@@ -177,6 +177,13 @@ func migrate_0_6_1(config_obj *config_proto.Config) {
 		config_obj.Datastore.FilestoreDirectory = strings.TrimSuffix(
 			config_obj.Datastore.FilestoreDirectory, "/")
 	}
+
+	if config_obj.Defaults == nil {
+		config_obj.Defaults = &config_proto.Defaults{
+			HuntExpiryHours:        24 * 7,
+			NotebookCellTimeoutMin: 10,
+		}
+	}
 }
 
 func migrate(config_obj *config_proto.Config) {