Skip to content

Adds Aeryn functionality. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2018
Merged

Adds Aeryn functionality. #4

merged 2 commits into from
Jan 4, 2018

Conversation

ashfurrow
Copy link
Member

This PR adds functionality to automatically invite new contributors to the RxSwiftCommunity organization, replacing our Aeryn server. Tracked in RxSwiftCommunity/contributors#36.

@orta there's one TODO that I copied from your implementation but I don't think it's required. Would you mind taking a quick look?

org/aeryn.ts Outdated
import { schedule, danger, markdown } from "danger"

// TODO: Needed?
declare const peril: any // danger/danger#351
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed 👍

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill the TODO and you're good.

@ashfurrow
Copy link
Member Author

Oops forgot to push 🙈

@freak4pc
Copy link
Member

freak4pc commented Jan 4, 2018

I’ll reviewnthis in a couple of hours if you don’t mind waiting a bit :)

@ashfurrow
Copy link
Member Author

No rush!

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight and to the point. Awesome !

@freak4pc freak4pc merged commit 6997e79 into master Jan 4, 2018
@ashfurrow ashfurrow deleted the aeryn branch January 4, 2018 21:36
@ashfurrow
Copy link
Member Author

Okay cool! I'll have to reboot the server, but I want to coordinate a shutdown of the Aeryn server (and test the code in prod), so I'll follow up in RxSwiftCommunity/contributors#36 when I have a few hours to monitor things.

@freak4pc
Copy link
Member

freak4pc commented Jan 4, 2018

@ashfurrow I can make a fake user to help test a merged commit on one of the repos later if you'd want, unless you thought of a less obtrusive testing mechanism 😄

@ashfurrow
Copy link
Member Author

I had not – was planning to use @ashfurrowbot 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants