-
Notifications
You must be signed in to change notification settings - Fork 3
Adds Aeryn functionality. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
org/aeryn.ts
Outdated
import { schedule, danger, markdown } from "danger" | ||
|
||
// TODO: Needed? | ||
declare const peril: any // danger/danger#351 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kill the TODO and you're good.
Oops forgot to push 🙈 |
I’ll reviewnthis in a couple of hours if you don’t mind waiting a bit :) |
No rush! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight and to the point. Awesome !
Okay cool! I'll have to reboot the server, but I want to coordinate a shutdown of the Aeryn server (and test the code in prod), so I'll follow up in RxSwiftCommunity/contributors#36 when I have a few hours to monitor things. |
@ashfurrow I can make a fake user to help test a merged commit on one of the repos later if you'd want, unless you thought of a less obtrusive testing mechanism 😄 |
I had not – was planning to use @ashfurrowbot 😉 |
This PR adds functionality to automatically invite new contributors to the RxSwiftCommunity organization, replacing our Aeryn server. Tracked in RxSwiftCommunity/contributors#36.
@orta there's one TODO that I copied from your implementation but I don't think it's required. Would you mind taking a quick look?