Remove retain cycle in the examples #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self was strongly referenced in most of the examples, thus creating a dependency cycle. This could easy be verified by checking the #debug logs: isDisposed was never called when navigating back from the controllers.
freak4pc
reviewed
Apr 27, 2019
| @@ -25,10 +25,11 @@ class FailedRequestViewController: UIViewController { | |||
| .didFailProvisionalNavigation | |||
| .observeOn(MainScheduler.instance) | |||
| .debug("didFailProvisionalNavigation") | |||
| .subscribe(onNext: {(webView, navigation, error) in | |||
| .subscribe(onNext: { [weak self] webView, navigation, error in | |||
| guard let strongSelf = self else { return } | |||
There was a problem hiding this comment.
can you do
Suggested change
| guard let strongSelf = self else { return } | |
| guard let self = self else { return } |
As available since Swift 4.2 ?
This is possible since Swift 4.2
|
Thanks a lot for contributing @NeverwinterMoon! I've invited you to join the Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self was strongly referenced in most of the examples, thus creating a dependency cycle. This could easy be verified by checking the #debug logs: isDisposed was never called when navigating back from the controllers.
Considering that people will use the examples as a reference, it seems weird to leave it as it was.