Make compatible with RxSwift 4.4.0 and Xcode 10.1 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone review it? @RxSwiftCommunity/contributors |
|
I'm a bit confused - If someone is using RxSwift 4.4.0, they would have no problem using this. There isn't really a compatibility issue that I see. Did you experience any issue here? |
|
@freak4pc my real problem is that I'm using Carthage and the latest version of RxKeyboard was compiled with Swift 4.1.2, and Xcode 10.1 version of swift is 4.2 |
|
Oh, it's a Carthage thing. Yeah, that one's tricky :) |
|
For while I forked this project and using deploy code on travis.yml, I generate a new zip artifact |
|
Can this be merged and a new binary built so we can use Carthage the easy way ? |
|
I think this is solved in #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.