Fixes security issue with upload and limits filetypes accepted #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FishHooks
approved these changes
Oct 19, 2021
mjschuetze102
approved these changes
Oct 19, 2021
|
We didn't make sure the session was started before saving data to it and since we didn't need to use session for anything previously, that was a pain to get in the proper place without errors. If the plug-in is unable to start the session when not running, it will log an error and the uploads will fail through the plug-in. |
mjschuetze102
approved these changes
Oct 21, 2021
FishHooks
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the recent security report on the plug-in, we are now checking file type inputs as well as implementing a simple CSRF token check for the upload page processor to limit the possibility of malicious file upload.