ctutils: remove (Partial)Eq impls for Choice
#1315
Merged
+86
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added in #1266 to simplify a migration from `subtle::Choice` with a TODO to eventually remove them. They're used in tests, including it seems, the ones for `ctutils`. They're problematic because the goal of `Choice` is to be an opaque boolean-alternative for use in constant-time code, but especially a derived `Partial(Eq)` can peek inside them and bypass the encapsulation they're trying to provide in a way that's easy to branch on. Now that `crypto-bigint` has actually been migrated to `ctutils`, we can followup on removing these as part of some final breaking changes.
tarcieri
force-pushed
the
ctutils/remove-choice-partial-eq-impls
branch
from
df24fb3 to
fd07f8c
Compare
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added in #1266 to simplify a migration from
subtle::Choicewith a TODO to eventually remove them. They're used in tests, including it seems, the ones forctutils.They're problematic because the goal of
Choiceis to be an opaque boolean-alternative for use in constant-time code, but especially a derivedPartial(Eq)can peek inside them and bypass the encapsulation they're trying to provide in a way that's easy to branch on.Now that
crypto-biginthas actually been migrated toctutils, we can followup on removing these as part of some final breaking changes.