hybrid-array: add FromIterator impl
#1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For feature parity with `GenericArray`. It would be nice to have a fallible version of this which returns an error instead of panicking on length mismatch, but we'd first need to add `FromFn::try_from_fn` or thereabouts. This is enough to cover the immediate use cases in the meantime.
tarcieri
commented
Jan 10, 2024
|
|
||
| assert!( | ||
| iter.next().is_none(), | ||
| "too many items in iterator to fit in array" |
There was a problem hiding this comment.
Maybe these should both say "iterator should have exactly as many items as can fit in array"
There was a problem hiding this comment.
I think it could be useful to know whether you have more than needed or not enough elements in iterator to fill array. The other expect message can be "not enough items in iterator to fill array".
newpavlov
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For feature parity with
GenericArray.It would be nice to have a fallible version of this which returns an error instead of panicking on length mismatch, but we'd first need to add
FromFn::try_from_fnor thereabouts.This is enough to cover the immediate use cases in the meantime.