elliptic-curve: make NonZeroScalar::invert infallible
#894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `NonZeroScalar` means we'll never divide by 0, it's possible to make the implementation infallible. To accomplish this, `CtOption` is removed from the `Invert` trait's signature, and used as the result type for scalars that are potentially zero as part of the blanket impl of `Invert`. Fixes RustCrypto/elliptic-curves#499
tarcieri
force-pushed
the
elliptic-curve/infallible-nonzero-scalar-inversions
branch
from
44c72a1 to
712434d
Compare
tarcieri
deleted the
elliptic-curve/infallible-nonzero-scalar-inversions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
NonZeroScalarmeans we'll never divide by 0, it's possible to make the implementation infallible.To accomplish this,
CtOptionis removed from theInverttrait's signature, and used as the result type for scalars that are potentially zero as part of the blanket impl ofInvert.Fixes RustCrypto/elliptic-curves#499