elliptic-curve: add Reduce trait
#768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a trait for modular reduction, primarily intended for use cases like hashing to a field element. The trait is generic around a `UInt` to permit overlapping impls, allowing either "narrow" or "wide" reduction, selected by the size of the input.
This was referenced Sep 17, 2021
Member
Author
|
Will go ahead and merge this so we can try it out. Worst case we can back it out prior to another release. |
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 20, 2021
Adds trait impls to `k256::Scalar` and `p256::Scalar` for the newly introduced `Reduce` trait, replacing the previous inherent methods: RustCrypto/traits#768
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 20, 2021
Adds trait impls to `k256::Scalar` and `p256::Scalar` for the newly introduced `Reduce` trait, replacing the previous inherent methods: RustCrypto/traits#768
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trait for modular reduction, primarily intended for use cases like hashing to a field element.
The trait is generic around a
UIntto permit overlapping impls, allowing either "narrow" or "wide" reduction, selected by the size of the input.