elliptic-curve: SEC1 private key support #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/sec1-private-keys
branch
from
fe69962 to
ed8eaa0
Compare
Adds the following methods to `SecretKey`: - `from_sec1_der` - `from_sec1_pem` (requires `pem` feature) - `to_sec1_der` - `to_sec1_pem` (requires `pem` feature) These implement the SEC1 (RFC5915) ASN.1 DER encoding for elliptic curve private keys. These methods are extracted from and now consumed by the PKCS#8 implementation, as PKCS#8 is just a wrapper for this format when used with elliptic curve keys. It seems like it might be a good idea to eventually extract this into a `sec1` crate as a followup, providing a similar role to the `pkcs1` crate. This would allow a setup that works much more like the `rsa` crate does now, where impling `sec1` traits provides a blanket impl of PKCS#8 support.
tarcieri
force-pushed
the
elliptic-curve/sec1-private-keys
branch
from
ed8eaa0 to
63d800d
Compare
tarcieri
added a commit
that referenced
this pull request
Sep 15, 2021
This was accidentally hidden during the refactoring in #762
tarcieri
added a commit
that referenced
this pull request
Sep 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following methods to
SecretKey:from_sec1_derfrom_sec1_pem(requirespemfeature)to_sec1_derto_sec1_pem(requirespemfeature)These implement the SEC1 (RFC5915) ASN.1 DER encoding for elliptic curve private keys.
These methods are extracted from and now consumed by the PKCS#8 implementation, as PKCS#8 is just a wrapper for this format when used with elliptic curve keys.
It seems like it might be a good idea to eventually extract this into a
sec1crate as a followup, providing a similar role to thepkcs1crate. This would allow a setup that works much more like thersacrate does now, where implingsec1traits provides a blanket impl of PKCS#8 support.