elliptic-curve: add ScalarCore<C> type
#732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/generic-scalar
branch
6 times, most recently
from
65d003c to
cad793f
Compare
This is incremental work towards having a "one true scalar" type which is generic over elliptic curves, using `crypto-bigint` for the backing arithmetic. It's presently called `ScalarCore<C>` to prevent it from conflicting with the existing `Scalar<C>`, however the goal is to completely replace the current `Scalar<C>`. This commit also does the following: - Removes the `ScalarBytes<C>` type as `ScalarCore<C>` can subsume its previous use cases - Makes the `zeroize` crate a hard dependency (i.e. removes the `zeroize` feature, making it mandatory)
tarcieri
force-pushed
the
elliptic-curve/generic-scalar
branch
from
cad793f to
79bb2a7
Compare
tarcieri
changed the title
ScalarCore<C> type
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 3, 2021
Corresponding changes for RustCrypto/traits#732
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 3, 2021
Corresponding changes for RustCrypto/traits#732
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 3, 2021
Corresponding changes for RustCrypto/traits#732
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 3, 2021
Corresponding changes for: - RustCrypto/traits#732 - RustCrypto/signatures#356 This is an initial step towards having a generic `Scalar<C>` type which is reusable over elliptic curves. As part of these changes, `zeroize` was made a mandatory dependency.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 3, 2021
Corresponding changes for: - RustCrypto/traits#732 - RustCrypto/signatures#356 This is an initial step towards having a generic `Scalar<C>` type which is reusable over elliptic curves. As part of these changes, `zeroize` was made a mandatory dependency.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 3, 2021
) Corresponding changes for: - RustCrypto/traits#732 - RustCrypto/signatures#356 This is an initial step towards having a generic `Scalar<C>` type which is reusable over elliptic curves. As part of these changes, `zeroize` was made a mandatory dependency.
Merged
scv35
added a commit
to scv35/Signature-algorithms
that referenced
this pull request
Jul 4, 2025
Corresponding changes for RustCrypto/traits#732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incremental work towards having a "one true scalar" type which is generic over elliptic curves, using
crypto-bigintfor the backing arithmetic.It's presently called
ScalarCore<C>to prevent it from conflicting with the existingScalar<C>, however the goal is to completely replace the currentScalar<C>.This PR also does the following:
ScalarBytes<C>type asScalarCore<C>can subsume its previous use caseszeroizecrate a hard dependency (i.e. removes thezeroizefeature, making it mandatory)