Skip to content

elliptic-curve: fix FieldBytesEncoding ranges #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 3, 2023
Merged

elliptic-curve: fix FieldBytesEncoding ranges #1287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions elliptic-curve/src/field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ where
fn decode_field_bytes(field_bytes: &FieldBytes<C>) -> Self {
debug_assert!(field_bytes.len() <= Self::ByteSize::USIZE);
let mut byte_array = ByteArray::<Self>::default();
byte_array[..field_bytes.len()].copy_from_slice(field_bytes);
let offset = Self::ByteSize::USIZE - field_bytes.len();
byte_array[offset..].copy_from_slice(field_bytes);
Self::from_be_byte_array(byte_array)
}

Expand All @@ -43,8 +44,8 @@ where
let mut field_bytes = FieldBytes::<C>::default();
debug_assert!(field_bytes.len() <= Self::ByteSize::USIZE);

let len = field_bytes.len();
field_bytes.copy_from_slice(&self.to_be_byte_array()[..len]);
let offset = Self::ByteSize::USIZE - field_bytes.len();
field_bytes.copy_from_slice(&self.to_be_byte_array()[offset..]);
field_bytes
}
}