elliptic-curve: fix weak feature activation TODOs #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/fix-weak-feature-activation-todos
branch
from
d0b5e26 to
bb55412
Compare
These TODOs described a way to do a bit more fine-grained feature activation. Now that we've bumped MSRV and can do it, this addresses them. It also uses namespaced feature activation to enable the `sec1` feature when the `pkcs8` feature is enabled.
tarcieri
force-pushed
the
elliptic-curve/fix-weak-feature-activation-todos
branch
from
bb55412 to
260b261
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These TODOs described a way to do a bit more fine-grained feature activation.
Now that we've bumped MSRV and can do it, this addresses them.
It also uses namespaced feature activation to enable the
sec1feature when thepkcs8feature is enabled.