signature: relax Keypair type bounds
#1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AsyncKeypair trait might be useful for representing relationship between DigestSigner and DigestVerifier, RandomizedSigner and RandomizedVerifier, etc. in addition to just Signer/Verfifier pair. Relax type boundaries for the AsyncKeypair trait. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
The Keypair trait might be useful for representing relationship between DigestSigner and DigestVerifier, RandomizedSigner and RandomizedVerifier, etc. in addition to just Signer/Verfifier pair. Relax type boundaries for the Keypair trait. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Member
|
This is technically a breaking change, in that downstream consumers that can presently rely on However, given I just shipped the first impls of this trait yesterday and the day before, I think it's rather unlikely there are any current users of the trait in its current form and we can just yank the associated releases. I also strongly agree there's a rather big upside to being able to use this trait regardless of what other traits a given signature key type impls. |
tarcieri
changed the title
Keypair type bounds (#1106)
tarcieri
changed the title
Keypair type bounds (#1106)Keypair type bounds
Merged
tarcieri
added a commit
that referenced
this pull request
Sep 15, 2022
As of #1107 this trait is shaped the same as `Keypair`, so there's no need for it to continue to exist. It will be removed in the next breaking release.
tarcieri
added a commit
that referenced
this pull request
Sep 15, 2022
As of #1107 this trait is shaped the same as `Keypair`, so there's no need for it to continue to exist. It will be removed in the next breaking release.
tarcieri
added a commit
that referenced
this pull request
Sep 15, 2022
As of #1107 this trait is shaped the same as `Keypair`, so there's no need for it to continue to exist. It will be removed in the next breaking release.
Merged
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 15, 2022
Following RustCrypto/traits#1107 this relaxes the trait bounds to the minimum requirements.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 15, 2022
Following RustCrypto/traits#1107 this relaxes the trait bounds to the minimum requirements.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 15, 2022
Following RustCrypto/traits#1107 this relaxes the trait bounds to the minimum requirements.
Merged
scv35
added a commit
to scv35/Signature-algorithms
that referenced
this pull request
Jul 4, 2025
Following RustCrypto/traits#1107 this relaxes the trait bounds to the minimum requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Keypair trait might be useful for representing relationship between
DigestSigner and DigestVerifier, RandomizedSigner and
RandomizedVerifier, etc. in addition to just Signer/Verfifier pair.
Relax type boundaries for the Keypair and AsyncKeypair traits.
Fixes #1106