Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HC-128 and Fix HC-256 #283

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

quentin-k
Copy link

#219 This implementation of HC-128 does not yet have the test vectors. HC-256 was using a table size of 2660 instead of 2560, this does not cause issue with the generated key stream, but slightly lengthens the initialization time. The function h2 in HC-256 used self.ptable instead of self.qtable, this means that it does not apply linear masking when the stream is using h2. For inputs that never get output from h2 it gives the correct results, but once h2 is in use the values are incorrect.

@newpavlov
Copy link
Member

newpavlov commented Feb 10, 2022

Can you please rebase and update this PR to cipher v0.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants