Skip to content

ecdsa: use Scalar::invert_vartime for verification #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Feb 3, 2023
Merged

ecdsa: use Scalar::invert_vartime for verification #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,3 @@ members = [

[profile.dev]
opt-level = 2

[patch.crates-io.elliptic-curve]
git = "https://github.com/rustcrypto/traits.git"
4 changes: 2 additions & 2 deletions ecdsa/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ edition = "2021"
rust-version = "1.61"

[dependencies]
elliptic-curve = { version = "=0.13.0-pre.3", default-features = false, features = ["digest", "sec1"] }
elliptic-curve = { version = "=0.13.0-pre.4", default-features = false, features = ["digest", "sec1"] }
signature = { version = "2.0, <2.1", default-features = false, features = ["rand_core"] }

# optional dependencies
Expand All @@ -25,7 +25,7 @@ rfc6979 = { version = "=0.4.0-pre.0", optional = true, path = "../rfc6979" }
serdect = { version = "0.1", optional = true, default-features = false, features = ["alloc"] }

[dev-dependencies]
elliptic-curve = { version = "=0.13.0-pre.3", default-features = false, features = ["dev"] }
elliptic-curve = { version = "=0.13.0-pre.4", default-features = false, features = ["dev"] }
hex-literal = "0.3"
sha2 = { version = "0.10", default-features = false }

Expand Down
2 changes: 1 addition & 1 deletion ecdsa/src/hazmat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ where
fn verify_prehashed(&self, z: &FieldBytes<C>, sig: &Signature<C>) -> Result<()> {
let z = Scalar::<C>::reduce_bytes(z);
let (r, s) = sig.split_scalars();
let s_inv = *s.invert();
let s_inv = *s.invert_vartime();
let u1 = z * s_inv;
let u2 = *r * s_inv;
let x = ProjectivePoint::<C>::lincomb(
Expand Down