x509-cert: make name an owned type #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
unlike #768 let's try a cleaner git history! :) |
baloo
force-pushed
the
baloo/owned-api/v2-submit
branch
from
355f7bc to
3dd5e79
Compare
tarcieri
reviewed
Nov 27, 2022
tarcieri
reviewed
Nov 27, 2022
tarcieri
reviewed
Nov 27, 2022
tarcieri
reviewed
Nov 27, 2022
baloo
force-pushed
the
baloo/owned-api/v2-submit
branch
4 times, most recently
from
86b09c4 to
8dc0807
Compare
tarcieri
reviewed
Nov 28, 2022
baloo
force-pushed
the
baloo/owned-api/v2-submit
branch
from
8dc0807 to
dccebd9
Compare
baloo
force-pushed
the
baloo/owned-api/v2-submit
branch
from
dccebd9 to
64947d9
Compare
baloo
force-pushed
the
baloo/owned-api/v2-submit
branch
from
64947d9 to
32cc657
Compare
tarcieri
reviewed
Dec 13, 2022
tarcieri
reviewed
Dec 13, 2022
sorah
added a commit
to sorah/needroleshere
that referenced
this pull request
Nov 4, 2023
Resolve incompatibilities as follows: - src/certificate.rs: RustCrypto/formats#771 - src/cmd/serve.rs: Move to FromRequestParts and use headers crate - src/ecdsa_sha256.rs: RustCrypto/traits#1196 and RustCrypto/signatures#574 - src/error.rs: Remove Duplicates - src/identity.rs: Remove owned validation logic as it should be done at x509_cert::serial_number::SerialNumber<x509_cert::certificate::Rfc5280> - src/sign.rs: RustCrypto/RSA#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: breaking change.
This changes x509 from a zero copy type to an owned type.
This brings along a rewrite of
der::Anyand a newder::ByteVecto come closer toder::ByteSlicebackingder::AnyRef