pkcs5: remove DES encryption support #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes support for encrypting keys using 56-bit DES, which is trivially broken due to its small key size. This functionality is already gated under the off-by-default `des-insecure` feature, however there is little reason why anyone should be encrypting DES keys today, and is a potential sharp edge if someone accidentally configure this setting.
tarcieri
force-pushed
the
pkcs5/disable-des-encryption
branch
from
d8996dc to
f722884
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for encrypting keys using 56-bit DES, which is trivially broken due to its small key size.
This functionality is already gated under the off-by-default
des-insecurefeature, however there is little reason why anyone should be encrypting DES keys today, and is a potential sharp edge if someone accidentally configure this setting.