Skip to content

x509-cert: ensure pem reader accept preambles #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

baloo
Copy link
Member

@baloo baloo commented Jun 23, 2025

It is convenient to have the text form alongside a certificate for debug purpose.

This test ensures we can accpt them.

@tarcieri
Copy link
Member

Yep, pem-rfc7468 definitely supports “preambles”

(However, it’s currently intolerant of trailing text)

@baloo baloo changed the title x509-cert: pem reader is tolerant to comments x509-cert: ensure pem reader accept preambles Jun 23, 2025
It is convenient to have the text form alongside a certificate for debug
purpose.

This test ensures we can accpt them.
@baloo baloo force-pushed the baloo/x509-cert/pem-comments branch from 529f0a7 to 6ed7798 Compare June 23, 2025 01:53
@baloo baloo merged commit 08aace2 into RustCrypto:master Jun 23, 2025
54 checks passed
@baloo baloo deleted the baloo/x509-cert/pem-comments branch June 23, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants