der: simplify Header::peek and Tag::peek
#1886
Merged
+12
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can rely on the ability to clone the `Reader` to use the `Decode` implementation to implement peeking, so we don't need a separate bespoke implementation. This also avoids losing the `Reader` context while peeking.
tarcieri
force-pushed
the
der/simplified-peeking
branch
from
3644522 to
70a4f16
Compare
|
Ah, so |
|
It was only used in a couple places. If it were used in more, perhaps it could be brought back as a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rely on the ability to clone the
Readerto use theDecodeimplementation to implement peeking, so we don't need a separate bespoke implementation.This also avoids losing the
Readercontext while peeking.