der: replace ErrorKind::Truncated with ErrorKind::Incomplete
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames and replaces the previous `ErrorKind::Truncated` which carried no additional information with an `ErrorKInd::Incomplete` which carries the expected and actual lengths. This is useful for incremental processing where a reader might attempt to perform an I/O operation to further fill a buffer in the event that the document is incomplete. This commit includes a number of incidental changes to handle cases where `ErrorKind::Truncated` was inappropriately used before. One of the biggest is adding an error type to the `spki` crate in order to better signal the error conditions (e.g. `AlgorithmParametersMissing`) which were previously unhelpfully propagated as `der::ErrorKind::Truncated`.
tarcieri
force-pushed
the
der/incomplete-errorkind
branch
from
9c20a81 to
5600c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames and replaces the previous
ErrorKind::Truncatedwhich carried no additional information with anErrorKind::Incompletewhich carries the expected and actual lengths.This is useful for incremental processing where a reader might attempt to perform an I/O operation to further fill a buffer in the event that the document is incomplete.
This commit includes a number of incidental changes to handle cases where
ErrorKind::Truncatedwas inappropriately used before. One of the biggest is adding an error type to thespkicrate in order to better signal the error conditions (e.g.AlgorithmParametersMissing) which were previously unhelpfully propagated asder::ErrorKind::Truncated.