spki: borrow the public key in spki::from_key
#1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Guess I'll need to break this in two. |
Member
Author
|
I am surprised to see minimal version of x509 work here. I expected it to fail, is this not a breaking change?! |
Member
|
Not sure how it would be possible? |
baloo
force-pushed
the
baloo/spki/spki-from_key
branch
from
9df790c to
43f0929
Compare
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jan 4, 2024
Blocking on: - RustCrypto#1290 - RustCrypto#1296
`SubjectPublicKeyInfoOwned` does not require the ownership of the key. This is a breaking change.
baloo
force-pushed
the
baloo/spki/spki-from_key
branch
from
43f0929 to
24ef7f6
Compare
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jan 4, 2024
Blocking on: - RustCrypto#1290 - RustCrypto#1296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubjectPublicKeyInfoOwneddoes not require the ownership of the key.This is a breaking change.