pkcs8: impl From*Key/To*Key traits on Document types
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
pkcs8/impl-traits-on-doc-types
branch
from
5dd9173 to
2bd60fd
Compare
These types previously had similarly "shaped" inherent methods. This commit impls the traits instead, providing a common API, and better consistency with the `pkcs1` and `sec1` crates which work this way.
tarcieri
force-pushed
the
pkcs8/impl-traits-on-doc-types
branch
from
2bd60fd to
7061797
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types previously had similarly "shaped" inherent methods.
This commit impls the traits instead, providing a common API, and better consistency with the
pkcs1andsec1crates which work this way.