pkcs8: replace usages of expect with fallible methods
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several places where errors aren't expected to happen which previously used `expect` to raise panics in these cases. This means that the `pkcs8` crate is not panic-free in these cases. Many of them are handled more cleanly with ensured error propagation without the use of `expect`. Consumers of this crate who would like infallible APIs can call `expect` themselves in these cases.
tarcieri
force-pushed
the
pkcs8/replace-expect-with-fallible-methods
branch
from
dd85069 to
0c0f36e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where errors aren't expected to happen which previously used
expectto raise panics in these cases.This means that the
pkcs8crate is not panic-free in these cases. Many of them are handled more cleanly with ensured error propagation without the use ofexpect.Consumers of this crate who would like infallible APIs can call
expectthemselves in these cases.