k256: fast invert_vartime using Stein's algorithm
#743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapts the implementation originally contributed to the `p256` crate by @nickray to the `k256` crate. Implementation is checked against the constant-time `Scalar::invert` using proptests (where `Scalar::invert` is in turn proptested against `num-bigint`). It results in a ~9% ECDSA verification performance improvement according to our criterion benchmarks: ecdsa/verify_prehashed time: [67.681 µs 67.734 µs 67.796 µs] change: [-9.4013% -9.2055% -9.0011%] (p = 0.00 < 0.05) Performance has improved.
Member
|
Nice! LGTM |
Merged
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the implementation originally contributed to the
p256crate by @nickray to thek256crate.Implementation is checked against the constant-time
Scalar::invertusing proptests (whereScalar::invertis in turn proptested againstnum-bigint).It results in a ~9% ECDSA verification performance improvement according to our criterion benchmarks: