k256+p256+p384: add PrimeField constant tests
#737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for the `TWO_INV`, `ROOT_OF_UNITY`, and `ROOT_OF_UNITY_INV` constants, based on the tests generated via `ff_derive`. Some of them are currently failing and have been annotated with `#[ignore]` and a TODO comment.
tarcieri
commented
Feb 1, 2023
10 tasks
Member
Author
|
Note: they're copy-pasted for now, but once I get these all working (including |
Contributor
|
I think there are a few tests missing here:
|
Member
Author
|
Yeah as implied in the comment above yours the |
Member
Author
|
Whoa, just hit an ICE on stable Rust (looks like while compiling the dependencies): https://github.com/RustCrypto/elliptic-curves/actions/runs/4078778175/jobs/7029397528 Edit: filed an issue rust-lang/rust#107613 |
Member
Author
|
Okay, after an ICE and failures possibly related to GitHub rewriting OS package tarballs I'm going to land this while it's green. Will backfill a few additional tests and try to consolidate the definitions of the test into a reusable macro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the
TWO_INV,ROOT_OF_UNITY, andROOT_OF_UNITY_INVconstants, based on the tests generated viaff_derive.Some of them are currently failing and have been annotated with
#[ignore]and a TODO comment.