primeorder: algorithm specialization using equation_a::Is* ZSTs
#728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
primeorder/double-and-equation-a-marker-traits
branch
from
e9c12b3 to
bd62d1b
Compare
Extracts a `Double` trait (which should probably go in `elliptic_curve::ops`) which allows for multiple overlapping impls based on specific properties of the curve's a-coefficient. The previous inherent `double()` method is now gated on `CurveEquationAIsMinus3`.
tarcieri
force-pushed
the
primeorder/double-and-equation-a-marker-traits
branch
from
bd62d1b to
01485d9
Compare
Using marker traits doesn't permit overlapping impls
tarcieri
force-pushed
the
primeorder/double-and-equation-a-marker-traits
branch
from
9527f44 to
1741bac
Compare
tarcieri
changed the title
Double and CurveEquationA* marker traitsDouble and CurveEquationA* marker traits
tarcieri
changed the title
Double and CurveEquationA* marker traitsCurveEquationA* ZSTs
tarcieri
changed the title
CurveEquationA* ZSTsCurveEquationA* ZSTs
tarcieri
force-pushed
the
primeorder/double-and-equation-a-marker-traits
branch
from
3b80e6a to
8fe002e
Compare
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jan 27, 2023
This is useful for supporting multiple potential `Double` implementations in generic code. See RustCrypto/elliptic-curves#728 for an example.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jan 27, 2023
This is useful for supporting multiple potential `Double` implementations in generic code. See RustCrypto/elliptic-curves#728 for an example.
tarcieri
changed the title
CurveEquationA* ZSTsequation_a::Is* ZSTs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts a
Doubletrait (which should probably go inelliptic_curve::ops) which allows for multiple overlapping impls based on specific properties of the curve's a-coefficient.The previous inherent
double()method is now gated onequation_a::IsMinus3.