p256: use impl_field_element! macro
#635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the same macro as `p384` to define the `FieldElement` type. Isolates core arithmetic functionality in a `p256_64.rs` module, with the goal of eventually producing a 32-bit implementation as well. Also adds a `p256_32.rs` module which provides a skeleton of a 32-bit implementation, although most of the functionality is currently implemented in terms of 64-bit integers, with the goal of facilitating an incremental conversion to a 32-bit backend.
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2022
This applies a similar treatment from #635 to the scalar backend, clearing the way to implement a proper 32-bit backend for both the base and scalar fields.
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2022
This applies a similar treatment from #635 to the scalar backend, clearing the way to implement a proper 32-bit backend for both the base and scalar fields.
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2022
This applies a similar treatment from #635 to the scalar backend, clearing the way to implement a proper 32-bit backend for both the base and scalar fields.
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2022
This applies a similar treatment from #635 to the scalar backend, clearing the way to implement a proper 32-bit backend for both the base and scalar fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same macro as
p384to define theFieldElementtype.Isolates core arithmetic functionality in a
p256_64.rsmodule, with the goal of eventually producing a 32-bit implementation as well.Also adds a
p256_32.rsmodule which provides a skeleton of a 32-bit implementation, although most of the functionality is currently implemented in terms of 64-bit integers, with the goal of facilitating an incremental conversion to a 32-bit backend.