Factor SEC-1 serialization into elliptic-curve crate
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `from_affine_coords` method to `CompressedPoint` and `UncompressedPoint` which accepts a `ScalarBytes` for the x and y-coordinates. This is then used in the `k256` and `p256` crates to consolidate the duplicated SEC-1 serialization logic.
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 81.27% 81.38% +0.10%
==========================================
Files 12 12
Lines 1346 1343 -3
==========================================
- Hits 1094 1093 -1
+ Misses 252 250 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
from_affine_coordsmethod toCompressedPointandUncompressedPointwhich accepts aScalarBytesfor the x and y-coordinates.This is then used in the
k256andp256crates to consolidate the duplicated SEC-1 serialization logic.