Update ecdsa crate and leverage generic ECDSA implementations
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ecdsa-updates
branch
2 times, most recently
from
3ad2115 to
6a8905a
Compare
This updates the crates in this repo to leverage the following generic implementations recently added to the `ecdsa` crate: - Sign: RustCrypto/signatures#396 - Verify: RustCrypto/signatures#397 The `p256` crate is able to directly utilize the generic implementation from the `ecdsa` crate. The `k256` crate retains its previous custom implementation, which provides a secp256k1-specific take on public key recovery, but can also directly leverage optimizations for computing linear combinations, which there are not presently traits in `elliptic-curve` or `group` to express.
tarcieri
force-pushed
the
ecdsa-updates
branch
from
6a8905a to
0b0b7fd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the crates in this repo to leverage the following generic implementations recently added to the
ecdsacrate:SignPrimitive::try_sign_prehashedsignatures#396VerifyPrimitive::verify_prehashedsignatures#397The
p256crate is able to directly utilize the generic implementation from theecdsacrate.The
k256crate retains its previous custom implementation, which provides a secp256k1-specific take on public key recovery, but can also directly leverage optimizations for computing linear combinations, which there are not presently traits inelliptic-curveorgroupto express.