Skip to content

Conversation

@tarcieri
Copy link
Member

The FromDigest trait has been removed from the ecdsa crate, in favor of using the Reduce trait:

RustCrypto/signatures#372

This is the corresponding set of changes to the above upstream PR to the ecdsa crate which implements this change.

The `FromDigest` trait has been removed from the `ecdsa` crate, in favor
of using the `Reduce` trait:

RustCrypto/signatures#372

This is the corresponding set of changes to the above upstream PR to the
`ecdsa` crate which implements this change.
@codecov-commenter
Copy link

Codecov Report

Merging #438 (bb3f0ef) into master (e922692) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   64.49%   64.45%   -0.04%     
==========================================
  Files          28       28              
  Lines        3588     3584       -4     
==========================================
- Hits         2314     2310       -4     
  Misses       1274     1274              
Impacted Files Coverage Δ
k256/src/arithmetic/scalar.rs 83.97% <ø> (-0.12%) ⬇️
k256/src/ecdsa/sign.rs 18.51% <0.00%> (ø)
p256/src/arithmetic/scalar.rs 80.83% <ø> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e922692...bb3f0ef. Read the comment docs.

@tarcieri tarcieri merged commit 2d91c16 into master Sep 23, 2021
@tarcieri tarcieri deleted the k256+p256/replace-fromdigest-with-reduce branch September 23, 2021 19:52
This was referenced Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants