Skip to content

Conversation

@tarcieri
Copy link
Member

The case it's actually being used for in practice is much simpler and can be easily expressed using the current functionality.

The case it's actually being used for in practice is much simpler and
can be easily expressed using the current functionality.
@tarcieri tarcieri requested a review from fjarri September 13, 2021 14:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.70%. Comparing base (f594fd4) to head (ebea79b).
Report is 644 commits behind head on master.

Files with missing lines Patch % Lines
k256/src/arithmetic/scalar/wide32.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   64.74%   64.70%   -0.04%     
==========================================
  Files          28       28              
  Lines        3602     3598       -4     
==========================================
- Hits         2332     2328       -4     
  Misses       1270     1270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjarri
Copy link
Contributor

fjarri commented Sep 14, 2021

Just as a general information: in libsecp256k1, the analogue of this function (secp256k1_scalar_cadd_bit()) is only ever used with a non-zero shift in secp256k1_wnaf_const().

@tarcieri tarcieri merged commit df71290 into master Sep 14, 2021
@tarcieri tarcieri deleted the k256/remove-conditional-add-bit branch September 14, 2021 01:28
This was referenced Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants