k256: remove force-32-bit feature
#399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was originally added for local testing purposes, but greatly complicates interactions with additional crates like `crypto-bigint` which are gated entirely on the target's word size. The testing workflow this provided can still be accomplished using a tool like `cross` by testing against a 32-bit target: ``` $ cross test --target powerpc-unknown-linux-gnu --release --all-features ``` Bonus points for testing against a big endian target to ensure there aren't any endian-related bugs as well. Breaking change in that it removes a feature.
tarcieri
commented
Aug 30, 2021
| @@ -1,3 +1,3 @@ | |||
| target | |||
| tests/Cargo.lock | |||
| **/Cargo.lock | |||
Member
Author
There was a problem hiding this comment.
One annoying thing about cross is it leaves behind a Cargo.lock file in the crate's directory (and for that matter, doesn't use the existing crate resolution) but this change at least prevents them from being checked in.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 59.44% 54.90% -4.55%
==========================================
Files 29 29
Lines 4207 4207
==========================================
- Hits 2501 2310 -191
- Misses 1706 1897 +191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was originally added for local testing purposes, but greatly complicates interactions with additional crates like
crypto-bigintwhich are gated entirely on the target's word size.The testing workflow this provided can still be accomplished using a tool like
crossby testing against a 32-bit target:Bonus points for testing against a big endian target to ensure there aren't any endian-related bugs as well.
Breaking change in that it removes a feature.