implement compact support for p256 #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Jun 14, 2021
madninja
changed the title
madninja
force-pushed
the
madninja/compact_point_impl
branch
from
c7fe19b to
e5bbcae
Compare
madninja
force-pushed
the
madninja/compact_point_impl
branch
from
e5bbcae to
76f547b
Compare
Fixes FieldElement forms to ensure they are in the right form for their two uses (AffinePoint appear to use the montgomery form, cmopact comparison needs canonical form)
Member
|
The cross-based test failures are not your fault. I'm going to go ahead and merge this and attempt to address them on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not quite be what you had in mind, especially with the modifications to field math to expose the borrow, but it was the shortest way to show what we'd done so far using the new elliptic curve traits