ed448-goldilocks: split Scalar into EdwardsScalar/DecafScalar
#1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
ed448-scalar-split
branch
2 times, most recently
from
e24ed71 to
45d1c82
Compare
Contributor
Author
|
Just realized that the scalar representation isn't the only difference that necessitates this change. Decaf448 also requires a different I went ahead and fixed that as well here. |
daxpedda
force-pushed
the
ed448-scalar-split
branch
from
0b0e1a6 to
a3a89d3
Compare
daxpedda
force-pushed
the
ed448-scalar-split
branch
from
a3a89d3 to
eb65078
Compare
tarcieri
changed the title
Scalar into EdwardsScalar and DecafScalarScalar into EdwardsScalar/DecafScalar
tarcieri
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Ed448 and Decaf448 have different scalar representations, we need two separate types.
This PR achieves this by making
Scalargeneric and adding two new types:type EdwardsScalar = Scalar<Ed448>type DecafScalar = Scalar<Decaf448>Scalaritself must still be publicly visible to allow its methods and implementations to show up in the documentation. A new private traitCurveWithScalaris introduced to let implementations differentiate between both curves. BecauseScalar<C: CurveWithScalar>relies on this private traitScalarcan't be used by users with other curves.Alternatively we could also achieve the same result with a huge macro instead of a shared generic
Scalartype. Let me know if you prefer that instead.Resolves #1229.