Expose AffineCoordinates::y
#1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/expose-affine-y-coordinate
branch
from
3655592 to
1f8924a
Compare
Companion PR to RustCrypto/traits#1891 which adds access to affine y-coordinates. Notably we've just added an Edwards curve with `ed448-goldilocks`, and these curves use compressed Edwards y-coordinates, so y-coordinate access is needed to even implement point compression generically for these curves. Note that due to #1229 it's currently not possible to impl the extened `AffineCoordinates API for the Decaf implementation in the `ed448-goldilocks` crate. This PR comments out the relevant code for now with a TODO to fix it.
tarcieri
force-pushed
the
elliptic-curve/expose-affine-y-coordinate
branch
from
1f8924a to
4d46c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to RustCrypto/traits#1891 which adds access to affine y-coordinates.
Notably we've just added an Edwards curve with
ed448-goldilocks, and these curves use compressed Edwards y-coordinates, so y-coordinate access is needed to even implement point compression generically for these curves.Note that due to #1229 it's currently not possible to impl the extened
AffineCoordinates API for the Decaf implementation in theed448-goldilocks` crate. This PR comments out the relevant code for now with a TODO to fix it.