Skip to content

ed448-goldilocks: reuse types from ed448 #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

baloo
Copy link
Member

@baloo baloo commented Jun 3, 2025

@baloo baloo force-pushed the baloo/ed448-use-signature branch 9 times, most recently from 714d642 to 90c4678 Compare June 4, 2025 02:17
@baloo baloo changed the title ed448: use ed448-signature ed448-goldilocks: use ed448-signature Jun 4, 2025
@baloo baloo force-pushed the baloo/ed448-use-signature branch 4 times, most recently from 61c487c to 99e558f Compare June 5, 2025 17:16
@tarcieri
Copy link
Member

tarcieri commented Jun 5, 2025

@baloo this looks like it needs to be updated to include RustCrypto/signatures#985

@baloo baloo force-pushed the baloo/ed448-use-signature branch from 99e558f to 8f7a3af Compare June 5, 2025 17:18
@tarcieri
Copy link
Member

tarcieri commented Jun 5, 2025

GitHub seems to be having a bad time. WTF is this?

bign256 / cross ... Cancelled after 1064745725m

Edit: githubstatus.com confirms they were having problems and just pushed out a fix. Gonna try kicking the failed jobs.

@baloo baloo force-pushed the baloo/ed448-use-signature branch 2 times, most recently from e85ca04 to 92687a9 Compare June 5, 2025 20:26
@baloo baloo changed the title ed448-goldilocks: use ed448-signature ed448-goldilocks: reuse types from ed448 Jun 5, 2025
@baloo baloo force-pushed the baloo/ed448-use-signature branch from 92687a9 to 62fd3e9 Compare June 5, 2025 20:43
@baloo baloo force-pushed the baloo/ed448-use-signature branch 3 times, most recently from d3481d8 to 55b4dae Compare June 6, 2025 14:44
@baloo baloo force-pushed the baloo/ed448-use-signature branch from 55b4dae to 497810e Compare June 6, 2025 16:19
@tarcieri
Copy link
Member

tarcieri commented Jun 6, 2025

Oh fun, rustfmt

@baloo
Copy link
Member Author

baloo commented Jun 6, 2025

my editor runs rustfmt on save, and for a reason I don't understand, for ed448-goldilocks it insists on having it formatted using edition 2021

EDIT: because there was a rustfmt.toml in the subdirectory that I've missed.

@baloo baloo force-pushed the baloo/ed448-use-signature branch from 497810e to 5426c16 Compare June 6, 2025 16:27
@tarcieri
Copy link
Member

tarcieri commented Jun 6, 2025

If your editor is IntelliJ, I have the same problem

@baloo
Copy link
Member Author

baloo commented Jun 6, 2025

no I use neovim and rust.vim, but it doesn't read the edition from the Cargo.toml and just runs rustfmt which is only configured using a rustfmt.toml.

I place a small rustfmt.toml in the root of the workspaces once they moved to 2024 edition:

edition = "2024"

and that has been working for me so far. I'd prefer having rust.vim or rustfmt respect the edition from Cargo.toml but I have absolutely no talent when it comes to writing vim plugins.

@baloo baloo force-pushed the baloo/ed448-use-signature branch from 5426c16 to b8981a4 Compare June 9, 2025 04:20
@baloo baloo force-pushed the baloo/ed448-use-signature branch from b8981a4 to a4dec96 Compare June 9, 2025 04:53
This was referenced Jun 9, 2025
@tarcieri tarcieri merged commit 23d743d into RustCrypto:master Jun 9, 2025
151 checks passed
@baloo baloo deleted the baloo/ed448-use-signature branch June 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants