Faster inversion modulo 2^k #932
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
feat/fast-inv-mod2k
branch
from
d0ff0c9 to
8fa4b67
Compare
kathleenmotley49-maker
approved these changes
Sep 4, 2025
kathleenmotley49-maker
approved these changes
Sep 4, 2025
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
fix repeated doubling in expand_invert_mod2k Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
feat/fast-inv-mod2k
branch
from
8fa4b67 to
ca97e01
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
tarcieri
reviewed
Sep 10, 2025
src/uint/ref_type.rs
Outdated
| @@ -92,12 +93,37 @@ impl UintRef { | |||
| self.0.iter_mut() | |||
| } | |||
|
|
|||
| /// Access the number of limbs. | |||
| #[inline] | |||
| pub const fn len(&self) -> usize { | |||
There was a problem hiding this comment.
This is fairly consistently fn nlimbs elsewhere, e.g. BoxedUint::nlimbs, or the nlimbs macro for Uint
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
feat/fast-inv-mod2k
branch
from
6edd45c to
8b39ccd
Compare
kathleenmotley49-maker
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invert_mod2kandinvert_mod2k_vartimeare optimized forUintandBoxedUint(often by 95% or more), which brings the performance ofinvert_modmuch closer toinvert_odd_mod.This depends on some of the updates in #930, and adds more functionality to
UintReffor operating on limb slices in const methods. Support for operating onOdd<UintRef>orNonZero<UintRef>is also added.