Classic Binary Extended GCD #854
Conversation
erik-3milabs
force-pushed
the
classic-xgcd
branch
3 times, most recently
from
f4eb716 to
b5dd779
Compare
erik-3milabs
force-pushed
the
classic-xgcd
branch
from
b5dd779 to
104a33a
Compare
|
@tarcieri this PR is ready for review. |
|
|
||
| pub(crate) struct ExtendedUint<const LIMBS: usize, const EXTENSION_LIMBS: usize>( | ||
| Uint<LIMBS>, | ||
| Uint<EXTENSION_LIMBS>, | ||
| ); | ||
|
|
||
| impl<const LIMBS: usize, const EXTRA: usize> ExtendedUint<LIMBS, EXTRA> { | ||
| /// Construct an [ExtendedUint] from the product of a [Uint<LIMBS>] and an [Uint<EXTRA>]. |
There was a problem hiding this comment.
Using this syntax will linkify the resulting rustdoc:
| /// Construct an [ExtendedUint] from the product of a [Uint<LIMBS>] and an [Uint<EXTRA>]. | |
| /// Construct an [`ExtendedUint`] from the product of a [`Uint<LIMBS>`] and an [`Uint<EXTRA>`]. |
There was a problem hiding this comment.
Note: there seem to be several instances of this below, including ones I didn't catch before
There was a problem hiding this comment.
Going to approve this PR but it would be good to get any of these which are visible in public rustdoc fixed up
There was a problem hiding this comment.
Using this syntax will linkify the resulting rustdoc:
You're absolutely correct that it is good thing to add those...
... which I'll have to do that in the next PR, given that you already merged this one 🙈
There was a problem hiding this comment.
(Also, on my end [Uint<LIMBS>] links to Uint and gets displayed as Uint, while
[`Uint<LIMBS>`]
still links to Uint but gets formatted as Uint<LIMBS>.
So, the backticks just add the LIMBS, but not the link.)
There was a problem hiding this comment.
Also, there is a difference in the formatting. Adding backticks also formats the word as code, instead of just text.
This PR introduces the binary extended GCD algorithm, and all the boiler plate code necessary to use the xgcd algorithm.
Supersedes #761.