Rename MontyForm => FixedMontyForm
#1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI @andrewwhitehead @fjarri this would be a breaking change |
tarcieri
commented
Jan 21, 2026
tarcieri
commented
Jan 21, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1145 +/- ##
=======================================
Coverage 80.68% 80.69%
=======================================
Files 178 178
Lines 18946 18954 +8
=======================================
+ Hits 15287 15295 +8
Misses 3659 3659 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tarcieri
force-pushed
the
rename-fixed-monty-form
branch
2 times, most recently
from
f6cd57c to
ada2c70
Compare
I find myself personally never using `MontyForm` (though I guess I might if we try `no_alloc` in `rsa`), and it's kind of bothered me that it has such a choice name while things I am using like `Monty` and `GenericMontyParams` seem to have somewhat suboptimal names. This commit renames `FixedMontyParams` which gives it more of an equal position to the other two and unlocks the names `MontyForm` and `MontyParams` for functionality which is common to all of the different implementations. It also renames the following: - `MontyParams` => `FixedMontyParams`: this follows from above, these are the params that go with `FixedMontyForm` (NOTE: they're also used by `ConstMontyForm`, so not sure if this rename will make that more confusing or not) - `GenericMontyParams` => `MontyParams`: this is the one generic type for Montgomery params. It's definitely quite helpful when writing generic code. - `Monty` => `MontyForm`: we named it the former because `MontyForm` was previously taken, but the name is otherwise ambiguous: is it a trait for `MontyForm` or `MontyParams`? This rename makes it clear that this is the trait for `*MontyForm` types. Closes #1141
tarcieri
force-pushed
the
rename-fixed-monty-form
branch
from
ada2c70 to
c5462ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself personally never using
MontyForm(though I guess I might if we tryno_allocinrsa), and it's kind of bothered me that it has such a choice name while things I am using likeMontyandGenericMontyParamsseem to have somewhat suboptimal names.This commit renames
MontyFormtoFixedMontyFormwhich gives it more of an equal position to the other two and unlocks the namesMontyFormandMontyParamsfor functionality which is common to all of the different implementations.It also renames the following:
MontyParams=>FixedMontyParams: this follows from above, these are the params that go withFixedMontyForm(NOTE: they're also used byConstMontyForm, so not sure if this rename will make that more confusing or not)GenericMontyParams=>MontyParams: this is the one generic type for Montgomery params. It's definitely quite helpful when writing generic code.Monty=>MontyForm: we named it the former becauseMontyFormwas previously taken, but the name is otherwise ambiguous: is it a trait forMontyFormorMontyParams? This rename makes it clear that this is the trait for*MontyFormtypes.Closes #1141