BoxedMontyForm: From conversions for (Const)MontyForm
#1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for converting from `ConstMontyForm` and `MontyForm` into `BoxedMontyForm`. This is useful for SRP where I'm trying to use `ConstMontyForm` and `ConstMontyParams` to represent groups as precomputed constants which can be converted to the heap allocated types to perform `modpow`, which currently isn't impl'd for the stack allocated types. Sidebar: it would be nice to fix that too.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 79.34% 79.25% -0.09%
==========================================
Files 176 177 +1
Lines 18058 18076 +18
==========================================
- Hits 14328 14327 -1
- Misses 3730 3749 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for converting from
ConstMontyFormandMontyFormintoBoxedMontyForm.This is useful for SRP where I'm trying to use
ConstMontyFormandConstMontyParamsto represent groups as precomputed constants which can be converted to the heap allocated types to performmodpow, which currently isn't impl'd for the stack allocated types.Sidebar: it would be nice to fix that too.