aes: refactor ARMv8 expand_key#367
Merged
Merged
Conversation
Changes `expand_key` to an `unsafe fn` that uses `target_feature`. Removes the TODOs: due to AES-192 this function can't be easily refactored to use `vinterpretq_u8_u32`.
Merged
newpavlov
added a commit
that referenced
this pull request
Apr 10, 2026
### Changed - Bump `cipher` dependency to v0.5 - Edition changed to 2024 and MSRV bumped to 1.85 ([#472]) - Refactor ARMv8 `expand_key` ([#367]) - Added `#[inline]` attributes for `KeyInit::new` impls ([#386]) - Rework backends ([#442]) - Move `Block8` to the hazmat module ([#468]) - Relax MSRV policy and allow MSRV bumps in patch releases ([#477]) - Replace inline ASM with ARMv8 intrinsics ([#380]) - Enable ARMv8 backend by default ([#395]) [#367]: #367 [#380]: #380 [#386]: #386 [#395]: #395 [#442]: #442 [#468]: #468 [#472]: #472 [#477]: #477
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
expand_keyto anunsafe fnthat usestarget_feature.Removes the TODOs: due to AES-192 this function can't be easily refactored to use
vinterpretq_u8_u32.