Skip to content

Add support for Codspeed performance testing#20

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
bifurcation:codspeed
May 31, 2024
Merged

Add support for Codspeed performance testing#20
tarcieri merged 1 commit intoRustCrypto:masterfrom
bifurcation:codspeed

Conversation

@bifurcation
Copy link
Contributor

No description provided.

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't heard of this before but it looks interesting

@tarcieri tarcieri merged commit bcfd143 into RustCrypto:master May 31, 2024
@tarcieri
Copy link
Member

@bifurcation something else that might be interesting is cargo-checkct: https://www.ledger.com/blog-cargo-checkct-our-home-made-tool-guarding-against-timing-attacks-is-now-open-source

- uses: dtolnay/rust-toolchain@master
with:
toolchain: stable
- run: cargo install cargo-codspeed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will compile cargo-codspeed on each CI run, which is really inefficient. It's better to use pre-compiled releases, e.g. see how we handle cargo-hack installation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will try to get things working and then optimize :)

@bifurcation
Copy link
Contributor Author

@tarcieri Sorry, should have marked this as draft! I'm just playing around with it at this point. I don't think the current rev even works. (Note that there are no real CI checks, since I broke the YAML file.) Probably best to revert until this is debugged.

tarcieri added a commit that referenced this pull request May 31, 2024
@tarcieri
Copy link
Member

tarcieri commented May 31, 2024

Opened #21 to revert (the GitHub UI for YAML parse failures is awkwardly deceptive, unfortunately)

tarcieri added a commit that referenced this pull request May 31, 2024
bifurcation added a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants