implement Decapsulate and Encapsulate from traits/kem#15
Merged
tarcieri merged 5 commits intoRustCrypto:masterfrom Apr 17, 2024
Merged
implement Decapsulate and Encapsulate from traits/kem#15tarcieri merged 5 commits intoRustCrypto:masterfrom
tarcieri merged 5 commits intoRustCrypto:masterfrom
Conversation
tarcieri
approved these changes
Apr 17, 2024
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
This seems like a good start.
Perhaps open an issue about EncapsulateDeterministic on the traits repo?
tarcieri
requested changes
Apr 17, 2024
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Needs rustfmt and the trait isn't in scope everywhere it needs to be for the tests.
Also perhaps disable the minimal-versions check for now? Here's an example:
Contributor
Author
|
Somehow adding the statement UPDATE: it seems like it was the doc test which confused me for more than I would like to admit |
added 2 commits
April 17, 2024 12:21
Member
|
Looks like one more import is needed |
tarcieri
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates ml-kem as advertised. this keeps EncapsulateDeterministic inside ml-kem though, perhaps this trait also deserves promotion to kem?