Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsalsa20poly1305: remove source code #543

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

tarcieri
Copy link
Member

The successor is the crypto_secretbox crate:

https://github.com/RustCrypto/nacl-compat/tree/master/crypto_secretbox

@tarcieri tarcieri merged commit e94ba5a into master Jul 22, 2023
81 checks passed
@tarcieri tarcieri deleted the xsalsa20poly1305/remove-source-code branch July 22, 2023 19:47
@jrose-signal
Copy link

jrose-signal commented Aug 22, 2023

If I look at the docs for crypto_secretbox it still suggests to use xsalsa20poly1305:

I could ask what changed, but that's probably not important, so I'll just stick with "is the current release up to date other than that"?

I misread "xsalsa20poly1305" as "xchacha20poly1305", no action needed. Though I'll note that deleting the changelog has added to the confusion here.

@tarcieri
Copy link
Member Author

Yeah, xsalsa20poly1305 is retired, replaced by crypto_secretbox which supports both XSalsa20Poly1305 and libsodium-flavored XChaCha20Poly1305.

I could potentially add the CHANGELOG.md back but I'd really like to just completely delete the xsalsa20poly1305 directory at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants