Skip to content

Update bindgen to make builds (even!) lighter #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

prokopyl
Copy link
Member

This pulls in the latest update of bindgen, which contains some work I did in harryfei/which-rs#14 and rust-lang/rust-bindgen#1625 to further reduce the amount of indirect dependencies we have, and thus build times as well. 🙂

Basically, bindgen depends on the which crate, which had a mandatory dependency on failure which bindgen did not use at all. I removed the dependency in those two PRs, making all bindgen users free of having to pull failure as well as its own dependencies (most problematic being backtrace).

For us, this removes another 10 seconds of build times on my machine (from 1m28s to 1m18s). 🙂

This PR also updates the syn and quote crates to their 1.0 version, as I noticed bindgen depended on them as well, and we ended up having two different versions in the dependency tree.

@prokopyl prokopyl self-assigned this Oct 23, 2019
@JOOpdenhoevel
Copy link
Contributor

It's only a change from 53s to 47s on my machine, but a good change nonetheless!

@JOOpdenhoevel JOOpdenhoevel merged commit ff0151d into master Oct 23, 2019
@JOOpdenhoevel JOOpdenhoevel deleted the bindgen-update branch October 23, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants