fix: empty source exhaustion #822
Merged
+128
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Empty: make unit struct, derive Default, and implement Iterator::size_hint and ExactSizeIterator. * Zero: derive Copy; implement size_hint, total_duration and try_seek; and fix current_span_len to return total span length.
|
I confirm that this fixes both the core issue descrbed in my initial discord message regarding this matter and also the one described here. When playing back the encoded data to the target hardware device, i no longer have decoding problems during the first moments of playback. |
Member
Author
|
Perfect, considering it solved. Thank you for your prompt feedback. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few related issues with how the queue handles empty/exhausted sources and their metadata. Issue reported on Discord here: https://discord.com/channels/590254806208217089/1394057870466744411/1455547213328683110.
Issue summary
Appending a source with different
channels/sample_rateto an empty queue would use wrong metadata during theUniformSourceIteratorsetup, causing resampling with incorrect parameters.Changes
Queuenow properly reports metadata from the next queued source instead of hardcoded silence values, preventing resampling issues when appending sourcesQueueuses the current source's metadata when generating keep-alive silence chunksEmptynow properly reports exhaustion viacurrent_span_len() = Some(0).Opportunistic refactoring
Emptynow properly implementssize_hintandExactSizeIteratorZeronow properly implementssize_hint,try_seekandtotal_durationimplementations, plusCopyderive