-
Notifications
You must be signed in to change notification settings - Fork 474
remove platform dependent unused stuff from sdl_bindings.rs, update sdl and dependencies #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ef0e40d to
f322edb
Compare
…dent unused stuff from sdl_bindings.rs
4ff65a7 to
84c9527
Compare
|
I set it to ready to review earlier, but now it is actually ready. I also have a suspicion as to why the CI fails, at least only the windows case (not the vcpkg case): |
|
56a65ed is a small otherwise unrelated change I added (I need Default for keyboard::Mod). It is documented in the changelog as well. |
|
looks fine to me. @Cobrand |
fix ci?-> later prcheck generated sdl_bindings.rs in ci?-> later pr or maybe notcloses #1496
closes #1500