ByteAddressableBuffer: fix mixed scalar and scalar pair stores #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
commented
Oct 8, 2025
| callee_ty: Self::Type, | ||
| _fn_attrs: Option<&CodegenFnAttrs>, | ||
| _fn_abi: Option<&FnAbi<'tcx, Ty<'tcx>>>, | ||
| fn_abi: Option<&FnAbi<'tcx, Ty<'tcx>>>, |
There was a problem hiding this comment.
I hope just using the one given to me is correct here, previously the FnAbi was computed from:
But it was in a function that wasn't given an
FnAbi but a rustc_middle::ty::Instance, which I never interacted with.
eddyb
approved these changes
Oct 11, 2025
Comment on lines
-158
to
-161
| let mode = &fn_abi.args.last().unwrap().mode; | ||
| self.buffer_store_intrinsics | ||
| .borrow_mut() | ||
| .insert(def_id, mode); |
There was a problem hiding this comment.
Oh wow, so being keyed on the DefId of a generic function meant that the last instance would win, and every call would be expected to conform to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #428