Skip to content

ci: replace spirv-tools prebuilds with vulkan sdk from lunarg #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jun 11, 2025

While caching is enabled, it seems like github runners don't care, so we got to redownload the sdk every time.

This even speeds up CI:

  • windows: 1m19 -> 7s
  • linux: 32s -> 23s
  • mac: 35s -> 32s

@Firestar99 Firestar99 marked this pull request as ready for review June 11, 2025 09:08
@Firestar99 Firestar99 enabled auto-merge June 11, 2025 09:08
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@Firestar99 Firestar99 added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit fbe8893 Jun 11, 2025
13 checks passed
@Firestar99 Firestar99 deleted the install-tools-from-vulkan-sdk branch June 11, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants